Skip to content

Remove TestData from series-tests test_repr.py #29148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

SaturnFromTitan
Copy link
Contributor

@SaturnFromTitan SaturnFromTitan commented Oct 22, 2019

Part of #22550

  • Replaced TestData usage in pandas/tests/series/test_repr.py with fixtures
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff

@jreback jreback added the Testing pandas testing functions or related to the test suite label Oct 22, 2019
@jreback jreback added this to the 1.0 milestone Oct 22, 2019
@SaturnFromTitan SaturnFromTitan force-pushed the remove-testdata-in-series-tests_test_reor branch from 8767f06 to 010cad4 Compare October 22, 2019 13:23
@SaturnFromTitan
Copy link
Contributor Author

SaturnFromTitan commented Oct 22, 2019

I added a new empty_series fixture as it is mentioned in the issue description. I've seen more places where this can be used, so I hope this is fine with you

@SaturnFromTitan SaturnFromTitan force-pushed the remove-testdata-in-series-tests_test_reor branch 2 times, most recently from f7fa790 to 6dd0917 Compare October 22, 2019 18:30
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SaturnFromTitan SaturnFromTitan force-pushed the remove-testdata-in-series-tests_test_reor branch from 6dd0917 to 4460c21 Compare October 23, 2019 13:27
@SaturnFromTitan
Copy link
Contributor Author

Done ✅ Please have another look @jreback

@jreback jreback merged commit 0df22b6 into pandas-dev:master Oct 23, 2019
@jreback
Copy link
Contributor

jreback commented Oct 23, 2019

thanks

HawkinsBA pushed a commit to HawkinsBA/pandas that referenced this pull request Oct 29, 2019
Reksbril pushed a commit to Reksbril/pandas that referenced this pull request Nov 18, 2019
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
bongolegend pushed a commit to bongolegend/pandas that referenced this pull request Jan 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants